-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend Strings Cleanup #3566
base: master
Are you sure you want to change the base?
Legend Strings Cleanup #3566
Conversation
The word color is currently used on this page. Of course, we can some day give options to the user to change the dot to look like a plus sign or a circle or a star ... |
When a heading says background, I expect everything in that section to be about background, and it is. The word Glucose is used on this page. xDrip is mainly about glucose. |
I think this is probably okay but it will trigger a lot of new translations |
Would it become acceptable if I break this into 2 PRs and you can merge them in sequence instead of in one shot? |
Its not the size of the PR it is the work we are asking others to do so we have to be sure we're not going to change our minds and alter it all again shortly afterwards. |
Now, I understand and agree. Just to let you know, we have a developer working on this: #3565 After I had that conversation, I realized that sooner or later, we may have one more item added to that menu. I have to say that menu looks too crowded to me. That was when I decided to clean it up. We can forget about this PR for now and wait for that work to complete. When/if that work is done, we can then decide how to deal with the menu including the new item. I agree 100%; creating unnecessary work for volunteers is unacceptable. Regardless, I am going to look at this PR now very carefully and review everything several times. I will also imagine that the new item has been added when I do the review and see if we need to make any changes to avoid any more changes needed later. |
I am suggesting some changes by removing some words that seem redundant to me.
Please let me know if you think this is not clear in English.