Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-language-translator #812

Closed
wants to merge 7 commits into from

Conversation

Nancyjikadra
Copy link
Contributor

issue assigned: #801

I have added python file for sign language translator along with readme file.

@Niketkumardheeryan kindly check it & merge it by assigning level under GSSoC'24.

@invigorzz313
Copy link
Contributor

@Nancyjikadra few points to note

  1. The PR must be made from a new branch instead of directly committing from master branch.
  2. The python code must be in a .ipynb file, not .py file. And with proper comments explaining the code.

@Nancyjikadra
Copy link
Contributor Author

@invigorzz313 Thank you for guiding me. I uploaded file in .ipynb format. Is there anything else I have to do to make this pr merge successfully?

@invigorzz313
Copy link
Contributor

invigorzz313 commented Jun 14, 2024

@Nancyjikadra I noticed there is no proper output. And for better readability, its good if the code is written in multiple cells with proper comments.
And as mentioned earlier, its better if the PR is made from a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants