Reviewed all modified modules and continued, made adjustments and continued with rehaul #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NiklasGustafsson !
I went over all the modified files in the PR in the dotnet repo. Mostly they were great - I made a slight adjustment here and there (like the wrong class name in
nameof
or a python naming change).All the modules that you moved to
ParamLess
but were still just a wrapper for the unmanaged object - I removed the unmanaged dependency. This took quite a lot of effort for the all the different pooling functions.In general, for pooling, the functions that return
with_indices
, I changed all the tuples to be named(Tensor Values, Tensor Indices)
to match other usages of that kind of tuple.I had two debates that I didn't put in yet for
Linear
andBilinear
:1] The constructor has an argument
hasBias
whereas in PyTorch it is justbias
. Is that worth fixing?2] The properties
in_features
etc. are public properties which can be modified - the question is whether we want to set them to be private set? I wasn't sure since theweight
field can be modified.