Add command to list configuration options #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 3, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 3, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 3, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 3, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 3, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 4, 2024
src/config.rs
Outdated
| @@ -163,6 +163,19 @@ pub trait Config: Default + PartialEq + DeserializeOwned + Serialize { | |||
| /// | |||
| /// Return false if the configuration does not support storing the migration version | |||
| fn set_migration_version(&mut self, _version: u32) -> bool; | |||
|
|
|||
| fn list_available_config(&self) -> &'static [ConfigField]; | |||
There was a problem hiding this comment.
nit: maybe just list_fields or fields for consistency with field and to be more concise?
src/admin.rs
Outdated
| @@ -69,6 +70,7 @@ enum Command { | |||
| FactoryReset, | |||
| #[cfg(feature = "factory-reset")] | |||
| FactoryResetApp, | |||
| ListAvailableConfig, | |||
There was a problem hiding this comment.
nit: I would just call it ListConfig/LIST_CONFIG to be less verbose, but that’s just a personal preference
There was a problem hiding this comment.
Intuitively, ListConfig would also return the values for each config field.
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 4, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 4, 2024
sosthene-nitrokey
force-pushed
the
list-options
branch
from
6f6a1dd
to
6bba27a
Compare
sosthene-nitrokey
force-pushed
the
list-options
branch
from
6bba27a
to
2bcefb3
Compare
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 4, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 4, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 7, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 7, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 8, 2024
robin-nitrokey
approved these changes
Oct 9, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 9, 2024
sosthene-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this is enough to go make the binary size too big. What a shame.