Add dynamic estimation of remaining credential space #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
dynamic-limit
branch
3 times, most recently
from
31aa18f
to
4faae1b
Compare
sosthene-nitrokey
force-pushed
the
dynamic-limit
branch
from
14422f1
to
2aef53a
Compare
sosthene-nitrokey
force-pushed
the
dynamic-limit
branch
from
2aef53a
to
4f8e8a4
Compare
|
This depends on trussed-dev/trussed-staging#27 |
Comment on lines
+393
to
+396
| >= self | ||
| .config | ||
| .max_resident_credential_count | ||
| .unwrap_or(MAX_RESIDENT_CREDENTIALS_GUESSTIMATE); |
There was a problem hiding this comment.
As we now always apply a hard limit, it would make sense to make the max_resident_credential_count configuration required and remove the guesstimate constant. This would also make the code easier to read.
sosthene-nitrokey
force-pushed
the
dynamic-limit
branch
from
fe94e0e
to
741348f
Compare
robin-nitrokey
approved these changes
Aug 1, 2024
daringer
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The estimation is pretty rough and in most cases pessimistic. It reserves multiple blocks of margin to prevent filling up the device.
With the default configuration of the usbip runner, it estimates the value to be around 40, and I could generate more than 60.
For now, this PR removes the hard-coded limitation when generating credentials.
This makes credential generation faster, but at the same time this could prove to be an issue when listing credential (even the USBIP version is pretty slow to list all credentials).