get_assertion: Skip attStmt unless requested #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verified using nk3am + firefox 131 + webauthn.io |
daringer
approved these changes
Oct 2, 2024
robin-nitrokey
force-pushed
the
get-assertion-att-stmt
branch
from
2d8629c
to
141abd7
Compare
For makeCredential, a missing attestation format preference list means that we should use the default format (packed). For getAssertion, it means that we should skip the attestation statement entirely. Previously, we implemented the makeCredential algorithm for both cases. This caused an incompatibility with firefox because it fails on unexpected fields in the response (in this case, the attestation statement). This patch fixes this issue and applies the correct default for getAssertion requests. Fixes: #98
robin-nitrokey
force-pushed
the
get-assertion-att-stmt
branch
from
141abd7
to
b34fa47
Compare
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 8, 2024
This patch updates fido-authenticator to fix compatibility with Firefox and also updates cbor-smol to 0.4.1. See also: - Nitrokey/fido-authenticator#99
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 9, 2024
This patch updates fido-authenticator to fix compatibility with Firefox and also updates cbor-smol to 0.4.1. See also: - Nitrokey/fido-authenticator#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For makeCredential, a missing attestation format preference list means that we should use the default format (packed). For getAssertion, it means that we should skip the attestation statement entirely. Previously, we implemented the makeCredential algorithm for both cases. This caused an incompatibility with firefox because it fails on unexpected fields in the response (in this case, the attestation statement). This patch fixes this issue and applies the correct default for getAssertion requests.
Fixes: #98