-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement short retries in single threaded context #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix round retry mechanism not being used for login This two are merged because the changing of the `next_instance` signature showed that `login()` did not use the retry mechanism
Instances stored a Arc reference in the background thread When `Finalize` is called, this thread would not get cleaned up. This instead uses `Weak` to clean it up over time in the worst case, all is cleaned up after 5 minutes
Once this is merged, we can fix #209:
|
@robin-nitrokey @daringer can you please review ? |
robin-nitrokey
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix round retry mechanism not being used for login This two are merged because the changing of the
next_instance
signature showed thatlogin()
did not use the retry mechanism.This does not count in the timeout calculation for each requests, so requests are limited to perform up to 3 health check at most (each with 1s timeout, so 3 seconds total).
This also makes all tests run both in single-threaded an multi-threaded modes.
This also removes some memory leaks in tests and in the
Finalize
call (the background thread did not close the instances it had.