Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cbor-smol #472

Closed
wants to merge 3 commits into from
Closed

Update cbor-smol #472

wants to merge 3 commits into from

Conversation

robin-nitrokey
Copy link
Member

No description provided.

@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Apr 5, 2024

metric value change
binary-size-nkpk 728591 -8383 (-0.01%)
Insignifcant changes
metric value change
binary-size-nk3am 1188509 -9135 (-0.01%)
binary-size-nk3am-test 2018402 🔴 +16667 (+0.01%)
binary-size-nk3xn 428036 -3328 (-0.01%)
binary-size-nk3xn-test 545552 -1952 (-0.00%)

@robin-nitrokey
Copy link
Member Author

binary-size-nk3xn-test:

PR value change to main
Nitrokey/cbor-smol#2 565,240 +17,736
Nitrokey/cbor-smol#3 553,520 +6,016
Nitrokey/cbor-smol#4 545,552 -1,952

@robin-nitrokey
Copy link
Member Author

@sosthene-nitrokey Should we merge this separately before #441 so that the cbor-smol update no longer affects the metrics for that PR? Alternatively, you can just use v0.4.0-nitrokey.3 in #441.

@sosthene-nitrokey
Copy link
Collaborator

I'll bump 441 to use the improved cbor-smol. Less merge conflicts.

@robin-nitrokey
Copy link
Member Author

Included in #441.

@robin-nitrokey robin-nitrokey deleted the cbor-smol branch April 5, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants