-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Validate lockfile #530
base: main
Are you sure you want to change the base?
Conversation
This patch adds a step to the build-firmware CI job that ensures that the lockfile is up-to-date. See also: Nitrokey/nethsm-pkcs11#221
No significant changes. Insignifcant changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In nethsm-pkcs11 I also made the lints run with --frozen
. That way the lints cannot be triggered for things that are not the result of the PR being checked.
Not sure when a lint could be triggered by a cargo update, but we never know.
The release builds should probably use |
I omitted that to keep the Makefile simple (we would only want to set it in CI, not for development) while still catching the most common issues. In what cases would |
It's not to check for failure, but to ensure sure that the lockfile is the correct description of the version used for releases. (reproducible builds etc...). To be frank I don't have intuition for exactly when |
This patch adds a step to the build-firmware CI job that ensures that the lockfile is up-to-date. See also: Nitrokey/nethsm-pkcs11#221