Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init appimage #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: init appimage #1

wants to merge 1 commit into from

Conversation

tomberek
Copy link
Collaborator

Creating an arbitrary appimage. Needs more ability to encode icons and other parameters.

@piegamesde
Copy link
Member

I'd be against forcefully providing a desktop entry. Graphical applications should always ship a .desktop file, which should be used. (For command line applications, generating a default desktop file based on the executable name is fine though.)

@tomberek
Copy link
Collaborator Author

@piegamesde agreed. Can you add the logic necessary to detect and find the desktop entry that may already be in the package?

@piegamesde
Copy link
Member

Probably not, sorry.

@ralismark
Copy link

This seems to break if packages contain broken relative symlinks.

I wasn't able to build a package that used python3.10.5 because I was getting this error:

error: builder for '/nix/store/w5z9zvip9nlq07vk5wha66q7iplifx5f-neovim-master.drv' failed with exit code 1;
       last 2 log lines:
       > cp: cannot stat '/nix/store/qm1agyi0bhnddhlhsrj9mq4v09kagxsg-hello.AppDir/hello.AppDir/nix/store/8mps2vhkrpy7g2vin9j7664m8gj56fpw-python3-3.10.5-env/include/python3.10/python3.10m': No such file or directory
       > cp: cannot stat '/nix/store/qm1agyi0bhnddhlhsrj9mq4v09kagxsg-hello.AppDir/hello.AppDir/nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/include/python3.10/python3.10m': No such file or directory
       For full logs, run 'nix log /nix/store/w5z9zvip9nlq07vk5wha66q7iplifx5f-neovim-master.drv'.

both /nix/store/8mps2vhkrpy7g2vin9j7664m8gj56fpw-python3-3.10.5-env/include/python3.10/python3.10m and /nix/store/9wa02q541sxq7372f8zv27rl57aribxj-python3-3.10.5/include/python3.10/python3.10m are broken symbolic links to ..python3.10m.

@tomberek
Copy link
Collaborator Author

tomberek commented Aug 6, 2022

Seems like this needs a cp -P option set.

@arximboldi
Copy link

This would be great. However, I expect it to inherit the same issues as nix-bundle when it comes to OpenGL applications?

ShamrockLee
ShamrockLee reviewed May 25, 2023
View reviewed changes
flake.nix
identity = drv: drv;
}
)) // {
x86_64-linux.toAppImage = (import ./appimage.nix {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppimageKit does support packaging for i686-linux and aarch64-linux. Is there a reason to only allow x86_64-linux AppImage bundling?

ShamrockLee
ShamrockLee reviewed May 25, 2023
View reviewed changes
appimage.nix
buildEnv {
name = "hello";
paths = [drv (
runCommand "appdir" {buildInputs = [imagemagick];} ''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runCommand "appdir" {buildInputs = [imagemagick];} ''
runCommand "appdir" {nativeBuildInputs = [imagemagick];} ''

@yakimant yakimant mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShamrockLee ShamrockLee ShamrockLee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomberek @piegamesde @ralismark @arximboldi @ShamrockLee