Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal2nix: resolve crypt library to libxcrypt #576

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Conversation

sternenseemann
Copy link
Member

NixOS has disabled glibc's libcrypt and is using libxcrypt now (starting with 22.11, that is): NixOS/nixpkgs#181764

This means we'll need to resolve the crypt identifier to libxcrypt. Releases including this commit need to go into NixOS unstable (as soon as the current staging iteration has finished) and NixOS 22.11. A release including this commit may not be backported to 22.05, as it'd likely break builds there.

NixOS has disabled glibc's libcrypt and is using libxcrypt now (starting
with 22.11, that is): NixOS/nixpkgs#181764

This means we'll need to resolve the crypt identifier to libxcrypt.
Releases including this commit need to go into NixOS unstable (as soon
as the current staging iteration has finished) and NixOS 22.11.
A release including this commit *may not* be backported to 22.05, as
it'd likely break builds there.
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

Great that one of our golden tests covered this as well.

@sternenseemann
Copy link
Member Author

Tested on current haskell-updates (the libxcrypt changes got merged), seems to work as intended. We should also make a release before 22.11.

@sternenseemann sternenseemann merged commit bf7cc8f into master Oct 22, 2022
@sternenseemann sternenseemann deleted the libxcrypt branch October 22, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants