Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_NIX_TEST_ACCEPT=1 does not work with meson #11369

Open
roberth opened this issue Aug 25, 2024 · 0 comments
Open

_NIX_TEST_ACCEPT=1 does not work with meson #11369

roberth opened this issue Aug 25, 2024 · 0 comments
Assignees
@Ericson2314
Labels
bug contributor-experience Developer experience for Nix contributors

Comments

@roberth
Copy link
Member

roberth commented Aug 25, 2024

Describe the bug

Steps To Reproduce

  1. Edit tests/function/lang/.exp
  2. meson test lang
  3. adapt the error message for meson test
  4. observe no difference: a stale framework.sh is used
  5. _NIX_TEST_ACCEPT=1 meson test lang
  6. no changes in git diff. presumably the correction is written to the copied files

Annoyances:

  • almost nothing is logged to the terminal, so we need to open the log file
  • testlog.txt stdout is out of sync with stderr

Expected behavior

When I run the message on screen, it fixes the actual sources.

nix-env --version output

Additional context

Priorities

Add 👍 to issues you find important.
@roberth roberth added bug contributor-experience Developer experience for Nix contributors labels Aug 25, 2024
@roberth roberth mentioned this issue Aug 28, 2024
Closed
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Nov 3, 2024
@Ericson2314
No longer copy functional tests to the build dir
37cefad 
This should make `_NIX_TEST_ACCEPT=1` work again, fixing NixOS#11369.

Progress on NixOS#2503
@Ericson2314 Ericson2314 mentioned this issue Nov 3, 2024
Merged
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Nov 3, 2024
@Ericson2314
No longer copy functional tests to the build dir
20fa5a6 
This should make `_NIX_TEST_ACCEPT=1` work again, fixing NixOS#11369.

Progress on NixOS#2503
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Nov 3, 2024
@Ericson2314
No longer copy functional tests to the build dir
b3e845b 
This should make `_NIX_TEST_ACCEPT=1` work again, fixing NixOS#11369.

Progress on NixOS#2503
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Nov 3, 2024
@Ericson2314
No longer copy functional tests to the build dir
9d2ed0a 
This should make `_NIX_TEST_ACCEPT=1` work again, fixing NixOS#11369.

Progress on NixOS#2503
Mic92 pushed a commit to Mic92/nix-1 that referenced this issue Nov 6, 2024
@Ericson2314 @Mic92
No longer copy functional tests to the build dir
2d68e36 
This should make `_NIX_TEST_ACCEPT=1` work again, fixing NixOS#11369.

Progress on NixOS#2503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ericson2314 Ericson2314

Labels
bug contributor-experience Developer experience for Nix contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roberth @Ericson2314