-Lsrc/libutil is too late in linker path, fails with a link error: download.cc:905: undefined reference to `nix::runProgram

[trofi]

The bug happens when I try to build nix-2.3 on a system with nix-2.2.2 installed in system (with /usr/lib64/libnixstore.so).

Linker pulls in system /usr/lib64/libnixstore.so and fails as:

nix-2.3 $ LANG=C make V=1
x86_64-pc-linux-gnu-g++ -std=c++17 -o /tmp/portage/sys-apps/nix-2.3/work/nix-2.3/src/libstore/libnixstore.so -shared -L/usr/lib64 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--no-copy-dt-needed-entries src/libstore/binary-cache-store.o src/libstore/build.o src/libstore/builtins/buildenv.o src/libstore/builtins/fetchurl.o src/libstore/crypto.o src/libstore/derivations.o src/libstore/download.o src/libstore/export-import.o src/libstore/gc.o src/libstore/globals.o src/libstore/http-binary-cache-store.o src/libstore/legacy-ssh-store.o src/libstore/local-binary-cache-store.o src/libstore/local-fs-store.o src/libstore/local-store.o src/libstore/machines.o src/libstore/misc.o src/libstore/nar-accessor.o src/libstore/nar-info-disk-cache.o src/libstore/nar-info.o src/libstore/optimise-store.o src/libstore/parsed-derivations.o src/libstore/pathlocks.o src/libstore/profiles.o src/libstore/references.o src/libstore/remote-fs-accessor.o src/libstore/remote-store.o src/libstore/s3-binary-cache-store.o src/libstore/sqlite.o src/libstore/ssh-store.o src/libstore/ssh.o src/libstore/store-api.o -lsqlite3 -lbz2 -lcurl -lsodium -pthread -ldl -lseccomp -Wl,-z,defs -Wl,-soname=libnixstore.so    -Wl,-rpath,/tmp/portage/sys-apps/nix-2.3/work/nix-2.3/src/libutil -Lsrc/libutil -lnixutil
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/libstore/build.o: in function `bool std::operator==<char, std::char_traits<char>, std::allocator<char> >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, char const*)':
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/include/g++-v9/bits/basic_string.h:6177: undefined reference to `nix::nativeSystem[abi:cxx11]'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/include/g++-v9/bits/basic_string.h:6177: undefined reference to `nix::nativeSystem[abi:cxx11]'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/include/g++-v9/bits/basic_string.h:6177: undefined reference to `nix::nativeSystem[abi:cxx11]'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/libstore/build.o: in function `nix::DerivationGoal::startBuilder()':
/tmp/portage/sys-apps/nix-2.3/work/nix-2.3/src/libstore/build.cc:2212: undefined reference to `nix::runProgram(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, std::__cxx11::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&)'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/libstore/download.o: in function `nix::Downloader::downloadCached(nix::ref<nix::Store>, nix::CachedDownloadRequest const&)':
/tmp/portage/sys-apps/nix-2.3/work/nix-2.3/src/libstore/download.cc:905: undefined reference to `nix::runProgram(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, std::__cxx11::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&)'
collect2: error: ld returned 1 exit status
make: *** [mk/lib.mk:104: src/libstore/libnixstore.so] Error 1

Note, the problem here is -L parameter ordering:
x86_64-pc-linux-gnu-g++ -std=c++17 -o .../libnixstore.so -shared -L/usr/lib64 ... -Lsrc/libutil -lnixutil. libnixstore.so is pulled from /usr/lib64.

Ideally linker flags should mention local paths first and then external ones.

[trofi]

I worked it around by reordering local and global LDFLAGS:
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-apps/nix/files/nix-2.3-libpaths.patch?id=7557065fb0a8b03218d6a67eca3771b1ca7382fd

[singron]

Do you accept pull requests? Is there anyone I can assign as reviewer to #3154? The Arch Linux User Repository (https://aur.archlinux.org/packages/nix) linked to my commit, and I'm mildly worried about unintentionally hosting unmerged changes for them.

[stale]

I marked this as stale due to inactivity. → More info