Rename commit-lockfile-summary to commit-lock-file-summary for consistency #10691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
new-cli
edolstra
approved these changes
May 13, 2024
grahamc
commented
May 13, 2024
| @@ -32,7 +32,7 @@ static void writeTrustedList(const TrustedList & trustedList) | |||
|
|
|||
| void ConfigFile::apply() | |||
| { | |||
| std::set<std::string> whitelist{"bash-prompt", "bash-prompt-prefix", "bash-prompt-suffix", "flake-registry", "commit-lockfile-summary"}; | |||
| std::set<std::string> whitelist{"bash-prompt", "bash-prompt-prefix", "bash-prompt-suffix", "flake-registry", "commit-lock-file-summary", "commit-lockfile-summary"}; | |||
There was a problem hiding this comment.
I wonder if this list is inclusive of aliases or not? I didn't want to break the users, though.
fricklerhandwerk
approved these changes
May 14, 2024
This was referenced Jun 28, 2024
Merged
cole-h
added a commit
to cole-h/nix
that referenced
this pull request
Jun 28, 2024
It was originally renamed in NixOS#10691, but NixOS#9063 accidentally removed the new name and alias.
cole-h
added a commit
to cole-h/nix
that referenced
this pull request
Jun 28, 2024
It was originally renamed in NixOS#10691, but NixOS#9063 accidentally removed the new name and alias.
rvolosatovs
added a commit
to rvolosatovs/nix-flake-update-action
that referenced
this pull request
Jul 12, 2024
NixOS/nix#10691 NixOS/nix#10988 Signed-off-by: Roman Volosatovs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Of the numerous commandline arguments that talk about the lock file, commit-lockfile-summary appears to be the only one without a hyphen. Rename it with a backwards compatibility alias.
Context
--commit-lockfile-summarybe renamed to--commit-lock-file-summary? #10687Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.