Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix3-build: show all FOD errors with --keep-going #10734

Merged
merged 1 commit into from
May 17, 2024

Commits on May 17, 2024

  1. nix3-build: show all FOD errors with --keep-going

    Basically I'd expect the same behavior as with `nix-build`, i.e.
    with `--keep-going` the hash-mismatch error of each failing
    fixed-output derivation is shown.
    
    The approach is derived from `Store::buildPaths` (`entry-point.cc`):
    instead of throwing the first build-result, check if there are any build
    errors and if so, display all of them and throw after that.
    
    Unfortunately, the BuildResult struct doesn't have an `ErrorInfo`
    (there's a FIXME for that at least), so I have to construct my own here.
    This is a rather cheap bugfix and I decided against touching too many
    parts of libstore for that (also I don't know if that's in line with the
    ongoing refactoring work).
    
    Closes https://git.lix.systems/lix-project/lix/issues/302
    
    Change-Id: I378ab984fa271e6808c6897c45e0f070eb4c6fac
    Signed-off-by: Jörg Thalheim <[email protected]>
    Ma27 authored and Mic92 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    19720d7 View commit details
    Browse the repository at this point in the history