fix NIX_PATH for real
#11079
Merged
fix NIX_PATH for real
#11079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Mic92
reviewed
Jul 11, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-07-17-nix-team-meeting-minutes-162/49255/1 |
- test restricted evaluation - test precedence for setting the search path
fricklerhandwerk
force-pushed
the
fix-nix-path-really-now
branch
from
d41543a
to
3b23fe6
Compare
roberth
reviewed
Jul 24, 2024
This ensures that the overriding happens even when no config file exists. This can happen when running Nix in a bare sandbox, for example.
NIX_CONF_DIR is not set when running the tests on NixOS.
roberth
force-pushed
the
fix-nix-path-really-now
branch
from
e6d06fc
to
82ec493
Compare
edolstra
reviewed
Jul 24, 2024
|
github flakes VM test is flaky; second occurrence I know of: https://github.com/NixOS/nix/actions/runs/10076791399/job/27857897291?pr=11079 I'm rerunning it. |
7 tasks
8 tasks
|
|
|
I am not sure in which version the bug first appeared but maybe we can backport this to 2.23 at least? |
|
Code has moved around a bit since 2.23, so git won't be of much help, but it's feasible. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-07-24-nix-team-meeting-minutes-164/49811/1 |
13 tasks
13 tasks
antoineco
added a commit
to antoineco/dotfiles
that referenced
this pull request
Sep 10, 2024
Since Nix 2.24, NIX_PATH overrides any setting defined in nix.conf[1]. This renders the 'extra-nix-path' option set by the installer[2] ineffective. The problem only affects nix-darwin. In NixOS, NIX_PATH is defaulted to the same value as the one set by the installer[3]. [1]: NixOS/nix#11079 [2]: https://github.com/DeterminateSystems/nix/blob/v2.24.6/flake.nix#L123 [3]: https://github.com/NixOS/nixpkgs/blob/nixos-24.05/nixos/modules/misc/nixpkgs-flake.nix#L96-L102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with @roberth
Motivation
closes #9574
Context
Based on #7871 and #8902
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.