SymbolStr: Remove std::string conversion #11082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring allows the symbol table to be stored as something other than std::strings.
github-actions
bot
added
new-cli
|
Looks alright. As a matter of practicality, do we merge this or #11072 first? Probably conflicts. |
|
#11072 is a big one that might need more review? It doesn't seem to conflict though. |
|
Tom has already reviewed most of it. Only the lexer part needs an extra pair of eyes. I kinda expected a conflict in the text, but I'll rebase it to make sure CI has run on the "merge". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows the symbol table to be stored as something other than
std::strings. Cherry-picked from #10938 where the symbol table is stored as contiguous null-terminated strings.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.