Deduplicate our many package.nix a bit
#11175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- They should all be built in parallel - They should all use strict deps by default
github-actions
bot
added
new-cli
Ericson2314
changed the title
package.nix a bitpackage.nix a bit
Ericson2314
commented
Jul 25, 2024
Comment on lines
-74
to
-75
| # TODO `releaseTools.coverageAnalysis` in Nixpkgs needs to be updated | ||
| # to work with `strictDeps`. |
fricklerhandwerk
approved these changes
Jul 25, 2024
Ericson2314
commented
Jul 25, 2024
Comment on lines
+153
to
+155
| (lib.extends | ||
| (lib.foldr lib.composeExtensions (_: _: {}) exts) | ||
| f); |
There was a problem hiding this comment.
Next time: composeManyExtensions
Ericson2314
added
the
contributor-experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
They should all be built in parallel
They should all use strict deps by default
Context
#2503
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.