Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 2.18-maintenance] AttrCursor: Remove forceErrors #11445

Merged
merged 5 commits into from
Sep 9, 2024
Merged

[backport 2.18-maintenance] AttrCursor: Remove forceErrors #11445

merged 5 commits into from
Sep 9, 2024

Commits on Sep 8, 2024

  1. Add test for the evaluation cache 

    (cherry picked from commit 8b86f41)
    @edolstra @eclairevoyant
    edolstra authored and eclairevoyant committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e3c55dd View commit details
    Browse the repository at this point in the history

  2. AttrCursor: Remove forceErrors 

    Instead, force evaluation of the original value only if we need to
show the exception to the user.

(cherry picked from commit 2c88930)
    @edolstra @eclairevoyant
    edolstra authored and eclairevoyant committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    8e5ec81 View commit details
    Browse the repository at this point in the history

  3. Typo 

    (cherry picked from commit eeb4c40)
    @edolstra @eclairevoyant
    edolstra authored and eclairevoyant committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fc14197 View commit details
    Browse the repository at this point in the history

  4. fix

    @eclairevoyant
    eclairevoyant committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ef63ba1 View commit details
    Browse the repository at this point in the history

  5. Store ref<EvalState> in CachedEvalError 

    This makes the previous commits work.
Newer versions store it in all EvalErrors.
    @roberth
    roberth committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5bcc706 View commit details
    Browse the repository at this point in the history