Fix making the build directory kept by keep-failed readable
#11473
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by 1d3696f Without this fix the kept build directory is readable only by root ``` $ sudo ls -ld /comp-temp/nix-build-openssh-static-x86_64-unknown-linux-musl-9.8p1.drv-5 drwx------ root root 60 B Wed Sep 11 00:09:48 2024 /comp-temp/nix-build-openssh-static-x86_64-unknown-linux-musl-9.8p1.drv-5/ $ sudo ls -ld /comp-temp/nix-build-openssh-static-x86_64-unknown-linux-musl-9.8p1.drv-5/build drwxr-xr-x nixbld1 nixbld 80 B Wed Sep 11 00:09:58 2024 /comp-temp/nix-build-openssh-static-x86_64-unknown-linux-musl-9.8p1.drv-5/build/ ```
Artturin
force-pushed
the
keepfailedreadable
branch
from
0a5a054
to
ebebe62
Compare
|
This should probably be backported down to 2.18, as the sandbox changes that caused this regression were backported too. |
Artturin
added
backport 2.18-maintenance
This was referenced Sep 11, 2024
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
roberth
added a commit
that referenced
this pull request
Sep 16, 2024
…1473 Fix making the build directory kept by `keep-failed` readable (backport #11473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by 1d3696f
Without this fix the kept build directory is readable only by root
Motivation
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.