Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressBar::ask: accept EOF, as a no #11816

Merged
merged 3 commits into from
Nov 6, 2024
Merged

ProgressBar::ask: accept EOF, as a no #11816

merged 3 commits into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. nix::readLine: Add eofOk parameter

    @roberth
    roberth committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f7b1e53 View commit details
    Browse the repository at this point in the history

  2. ProgressBar::ask: Accept EOF as a no 

    This may occur when stderr is a tty but stdin is empty.
E.g.

    $ nix build </dev/null
    error: unexpected EOF reading a line

These stdio handles are how some non-interactive sandboxes behave,
including the Nix build sandbox and Hercules CI Effects.
    @roberth
    roberth committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3112e59 View commit details
    Browse the repository at this point in the history

  3. refact: Remove unused arguments

    @roberth
    roberth committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c6c8d2a View commit details
    Browse the repository at this point in the history