Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libmain/common-args): do not exceed maximum allowed verbosity #11853

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(libmain/common-args): do not exceed maximum allowed verbosity #11853

merged 1 commit into from
Nov 13, 2024
+3 −1

Commits on Nov 13, 2024

  1. fix(libmain/common-args): do not exceed maximum allowed verbosity 

    This patch gets rid of UB when verbosity exceeds the maximum logging value of `lvlVomit = 7` and
reaches invalid values (e.g. 8). This is actually triggered in functional tests.
There are too many occurrences to list, but here's one from the UBSAN log:

../src/libstore/gc.cc:610:5: runtime error: load of value 8, which is not a valid value for type 'Verbosity'
    @xokdvium
    xokdvium committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b9f8c4a View commit details
    Browse the repository at this point in the history