preloadNSS / dns timeout #5384
Merged
preloadNSS / dns timeout #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 14, 2021
baloo
force-pushed
the
baloo/dns-timeout
branch
from
41a6044
to
39bb100
Compare
We can actually just load nss ourselves and call in nss to configure it and we don't need to run a dummy query entirely to have nss load nss_dns as a side-effect. Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/dns-timeout
branch
from
39bb100
to
ca8989d
Compare
edolstra
reviewed
Oct 15, 2021
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/dns-timeout
branch
from
0978eac
to
c345a4a
Compare
|
Builds on x86_64-linux. Limited testing of both nix and nix-static. While the method utilized is simpler and more appropriate, it does have the GNU-specific requirement. Would be good to explain/document the various nix/nix-static/darwin/etc implications and test them. |
|
@tomberek I pushed a comment, let me know what you think or if there is anything missing. |
tomberek
reviewed
Oct 16, 2021
tomberek
reviewed
Oct 16, 2021
tomberek
approved these changes
Oct 16, 2021
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/dns-timeout
branch
from
4a145ae
to
fa4abe4
Compare
|
@edolstra any chance to get a merge on this one? |
baloo
added a commit
to baloo/nix-1
that referenced
this pull request
Nov 25, 2021
backport of NixOS#5384 to nix 2.4
baloo
added a commit
to baloo/nix-1
that referenced
this pull request
Nov 25, 2021
backport of NixOS#5384 to nix 2.4
baloo
added a commit
to baloo/nix-1
that referenced
this pull request
Nov 25, 2021
backport of NixOS#5384 to nix 2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomberek was reporting dns timeout when running commands like
nix --version.Reading glibc again, I stumbled upon
__nss_configure_lookupwhich is actually exactly what we're trying to achieve.I think this simplifies the workaround a lot as it does not rely on a side-effect anymore, and is pretty straight-forward to understand.