-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save cwd fd instead of path #6386
base: master
Are you sure you want to change the base?
Conversation
I thought the FD method didn't work? I didn't follow the entire discussion though. |
Sorry I didn't make this part clear -- it didn't, but @Ericson2314 requested I resubmit this part as a draft so that someone in the future can try to take this further / investigate the exact issue behind it. |
Yeah because of things like #2759 I am very keen on doing as much as possible with file descriptors. So I figured I could assign this draft PR to myself to hopefully debug someday. |
@cole-h Would you know how to make a test here demonstrating the failure? |
Currently? No. But I'll give it a shot tomorrow and see if I can't make one. I'll probably start with just a simple reproducer using the magic of flakes and work my way to a more comprehensive test. |
This reverts commit 56009b2.
That would be wonderful, thanks in advance, @cole-h! |
4c4e9fe
to
7aebe91
Compare
(Rebased) OK, so here's a simple reproducer:
However, if you do I had a hard time trying to write a NixOS test for it, so this is the best I can do. |
This reverts commit 56009b2.
Submitted as a draft at the behest of @Ericson2314.
Note that this does not work, for some reason. See some of the discussion in #6348 for what went wrong (specifically, it appears to strip
/home/vin
from/home/vin/workspace/vcs/nix
for some unknown reason).