Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Always run with sandbox, even on Darwin #8240

Merged
merged 4 commits into from
May 26, 2023

Commits on May 26, 2023

  1. ci: Always run with sandbox, even on Darwin

    And fix a test failure in the sandbox due to /home
    existing on Darwin but not being accessible in the sandbox since it's a
    symlink to /System/Volumes/Data/home, see
    https://github.com/NixOS/nix/actions/runs/4205378453/jobs/7297384658#step:6:2127:
    
        C++ exception with description "error: getting status of /home/schnitzel/darmstadt/pommes: Operation not permitted" thrown in the test body.
    
    On Linux this wasn't a problem because there /home doesn't exist in the sandbox
    infinisil authored and yorickvP committed May 26, 2023
    Configuration menu
    Copy the full SHA
    be48907 View commit details
    Browse the repository at this point in the history
  2. Call getDefaultSSLCertFile() only when none is specified

    This does pathExists on various paths, which crashes on EPERM in the
    macOS sandbox.
    yorickvP committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b7cde90 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a6c78ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c46248 View commit details
    Browse the repository at this point in the history