-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchTree/fetchGit: add test for .gitattributes #9391
base: master
Are you sure you want to change the base?
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-11-20-nix-team-meeting-minutes-105/35902/1 |
Discussed in the Nix maintenance meeting. Not sure how to work forward with that (and #9240 probably just broke it), but we should at least either
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-11-24-nix-team-meeting-minutes-106/35955/1 |
e31e320
to
e5c6a9e
Compare
Rebased |
...with the intention to prevent future regressions in fetchGit
e5c6a9e
to
eec2312
Compare
I noticed there is actually another thing that gets processed by I added a commit to the current PR adding a test which passes on the current stable nix but fails on master. The bad news is that export-subst seems to be more complex to implement than export-ignore. I posted some more info on a related issue on libgit2: libgit2/libgit2#918 (comment) |
I wouldn't expect the log format to be particularly stable in future versions, so this could be painful to support. We'll probably want to support a subset, and error out if there's anything non-reproducible in there. |
...with the intention to prevent future regressions in fetchGit