nix repl: Only hide the progress bar while waiting for user input #9476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 0d2163c, the progress bar was hidden in nix repl because of a regression that caused it to interfere with user input. Several users like(d) seeing the progress bar in the repl during builds. Only hiding it while waiting for user input gives us the best of both worlds, so do just that.
github-actions
bot
added
the
repl
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
nix repl: Only hide the progress bar while waiting for user input (cherry picked from commit 3bebaef) Change-Id: Ie7c0db46f7c2cf5f938e66bdd3c31f0b62bdb104
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Observed to regress nix repl attrset printing with narrow windows. This reverts commit a2d5e80. Fixes: https://git.lix.systems/lix-project/lix/issues/168 Change-Id: I8e0031475b4ec26d6a71014357d973578b70815c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 0d2163c, the progress bar was hidden in nix repl because of a regression that caused it to interfere with user input. Several users like(d) seeing the progress bar in the repl during builds. Only hiding it while waiting for user input gives us the best of both worlds, so do just that.
Context
Mentioned in #9412.
Priorities
Add 👍 to pull requests you find important.