Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix shell: reflect command line order in PATH order #9648

Merged
merged 3 commits into from
Jan 9, 2024
Merged

nix shell: reflect command line order in PATH order #9648

merged 3 commits into from
Jan 9, 2024

Commits on Dec 21, 2023

  1. libcmd: Installable::toStorePaths -> Installable::toStorePathSet

    @cole-h
    cole-h committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    5ed1884 View commit details
    Browse the repository at this point in the history

  2. tests: add a test for command line ordering

    @cole-h
    cole-h committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1fb43d1 View commit details
    Browse the repository at this point in the history

  3. nix shell: reflect command line order in PATH order 

    Prior to this change, Nix would prepend every installable to the PATH
list in order to ensure that installables appeared before the current
PATH from the ambient environment.

With this change, all the installables are still prepended to the PATH,
but in the same order as they appear on the command line. This means
that the first of two packages that expose an executable `hello` would
appear in the PATH first, and thus be executed first.

See the test in the prior commit for a more concrete example.
    @cole-h
    cole-h committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f4454aa View commit details
    Browse the repository at this point in the history