Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Machine::systemTypes a set not vector #9838

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Make Machine::systemTypes a set not vector #9838

merged 3 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. Make Machine::systemTypes a set not vector 

    This is more conceptually correct (the order does not matter), and also
matches what Hydra already does.

(Nix and Hydra matching is needed for dedup
NixOS/hydra#1164)
    @Ericson2314
    Ericson2314 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7390327 View commit details
    Browse the repository at this point in the history

  2. Add API docs to Machine methods

    @Ericson2314
    Ericson2314 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    870acc2 View commit details
    Browse the repository at this point in the history

  3. Factor out Machine::systemSupported 

    There's just enough logic (the `"builtin"` special case) that makes this
worthy of its own method.
    @Ericson2314
    Ericson2314 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0aa8508 View commit details
    Browse the repository at this point in the history