Allow usage of generated SSH key even when there is no previous activation #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ethnt, According to the git blame, we switched to setting the authorized_keys via the NixOS configuration at some point 8ad1138 The original issue describes a situation where an activation did happen, in which case this change doesn't seem useful, unless NixOps is unaware that the activation succeeded. Maybe it isn't quite sure and the It seems like this is something we could write a regression test for, based on, or in: https://github.com/NixOS/nixops/blob/master/integration-tests/default.nix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re-implemented the code in #1157 after bringing it up to date with master. I think this would solve the issue mentioned at #904. If I need to add typing, please let me know 🙏
To add a bit of color: I had an initial deployment that failed (mostly related to usage of
sops-nix, but that feels unrelated). Subsequent deploys weren't able to be performed because it would never use the generated SSH key. This seems like it could be a semi-common condition — however, I'm not sure about the reasoning behind the original conditional.