Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starfive visionfive2: allow generic image to boot on all variants of boards #962

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented May 31, 2024

Description of changes

Tested on v1.3B 8GB version.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

u-boot is able to automatically set the correct device tree name
on VisionFive 2 boards by reading their EEPROM since v2023.10.

This allows our image to work with either revision of the boards.

Reference: u-boot/u-boot@16dbe3d
u-boot is able to automatically set the correct memory size in fdt
on VisionFive 2 boards by reading their EEPROM since v2023.10.

This allows our image to work with either variant of the boards.

Reference: u-boot/u-boot@38d900b
Reference: u-boot/u-boot@4317770
@NickCao
Copy link
Member Author

NickCao commented May 31, 2024

Finally got access to a new board! Please test on v1.2A and 4GB versions of boards if possible.

@NickCao
Copy link
Member Author

NickCao commented May 31, 2024

cc @malteneuss @onny @misuzu @0x4A6F

@malteneuss
Copy link
Contributor

Works on 1.3b 8GB board. And looking forward to testing the latest kernel.

@onny
Copy link
Contributor

onny commented May 31, 2024

Why is this patch not required anymore? Because we are already on mainline kernel? Does mainline boot without the patch?

@malteneuss
Copy link
Contributor

No, because we have quite a new uboot package in nixpkgs unstable that apparently can select the visionfive2 devices on its own.

@onny onny self-requested a review June 1, 2024 07:39
Copy link
Contributor

@onny onny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :)
1.3b 8GB board

@NickCao
Copy link
Member Author

NickCao commented Jun 1, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jun 1, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7b49d39

@mergify mergify bot merged commit 7b49d39 into NixOS:master Jun 1, 2024
3 checks passed
@malteneuss
Copy link
Contributor

@NickCao Any luck on getting the latest Linux kernel 6.9.2 to work?

@NickCao
Copy link
Member Author

NickCao commented Jun 8, 2024

@NickCao Any luck on getting the latest Linux kernel 6.9.2 to work?

See #964 for @onny 's attempt

@NickCao NickCao deleted the visionfive2-dtb branch June 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants