Skip to content

Commit

Permalink
nodePackages.node-pre-gyp: drop
Browse files Browse the repository at this point in the history
  • Loading branch information
dotlambda committed Aug 5, 2024
1 parent 17cc69f commit 92f5cb3
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 102 deletions.
1 change: 1 addition & 0 deletions pkgs/development/node-packages/aliases.nix
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ mapAliases {
musescore-downloader = pkgs.dl-librescore; # added 2023-08-19
inherit (pkgs) near-cli; # added 2023-09-09
node-inspector = throw "node-inspector was removed because it was broken"; # added 2023-08-21
inherit (pkgs) node-pre-gyp;
inherit (pkgs) nodemon; # added 2024-06-28
inherit (pkgs) npm-check-updates; # added 2023-08-22
ocaml-language-server = throw "ocaml-language-server was removed because it was abandoned upstream"; # added 2023-09-04
Expand Down
1 change: 0 additions & 1 deletion pkgs/development/node-packages/node-packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@
, "nijs"
, "node-gyp"
, "node-gyp-build"
, "node-pre-gyp"
, "node-red"
, "node2nix"
, "np"
Expand Down
89 changes: 0 additions & 89 deletions pkgs/development/node-packages/node-packages.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions pkgs/development/node-packages/overrides.nix
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ final: prev: {

libsecret
final.node-gyp-build
final.node-pre-gyp
node-pre-gyp

pixman
cairo
Expand Down Expand Up @@ -179,7 +179,7 @@ final: prev: {
};

node-red = prev.node-red.override {
buildInputs = [ final.node-pre-gyp ];
buildInputs = [ pkgs.node-pre-gyp ];
};

node2nix = prev.node2nix.override {
Expand Down Expand Up @@ -349,23 +349,23 @@ final: prev: {
});

thelounge-plugin-closepms = prev.thelounge-plugin-closepms.override {
nativeBuildInputs = [ final.node-pre-gyp ];
nativeBuildInputs = [ pkgs.node-pre-gyp ];
};

thelounge-plugin-giphy = prev.thelounge-plugin-giphy.override {
nativeBuildInputs = [ final.node-pre-gyp ];
nativeBuildInputs = [ pkgs.node-pre-gyp ];
};

thelounge-theme-flat-blue = prev.thelounge-theme-flat-blue.override {
nativeBuildInputs = [ final.node-pre-gyp ];
nativeBuildInputs = [ pkgs.node-pre-gyp ];
# TODO: needed until upstream pins thelounge version 4.3.1+ (which fixes dependency on old sqlite3 and transitively very old node-gyp 3.x)
preRebuild = ''
rm -r node_modules/node-gyp
'';
};

thelounge-theme-flat-dark = prev.thelounge-theme-flat-dark.override {
nativeBuildInputs = [ final.node-pre-gyp ];
nativeBuildInputs = [ pkgs.node-pre-gyp ];
# TODO: needed until upstream pins thelounge version 4.3.1+ (which fixes dependency on old sqlite3 and transitively very old node-gyp 3.x)
preRebuild = ''
rm -r node_modules/node-gyp
Expand Down Expand Up @@ -395,7 +395,7 @@ final: prev: {
vega-cli = prev.vega-cli.override {
nativeBuildInputs = [ pkgs.pkg-config ];
buildInputs = with pkgs; [
final.node-pre-gyp
node-pre-gyp
pixman
cairo
pango
Expand All @@ -422,7 +422,7 @@ final: prev: {
};

wavedrom-cli = prev.wavedrom-cli.override {
nativeBuildInputs = [ pkgs.pkg-config final.node-pre-gyp ];
nativeBuildInputs = [ pkgs.pkg-config pkgs.node-pre-gyp ];
# These dependencies are required by
# https://github.com/Automattic/node-canvas.
buildInputs = with pkgs; [
Expand Down
5 changes: 3 additions & 2 deletions pkgs/servers/jellyseerr/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
fetchFromGitHub,
fetchYarnDeps,
makeWrapper,
node-pre-gyp,
nodejs,
python3,
sqlite,
Expand Down Expand Up @@ -35,7 +36,7 @@ mkYarnPackage rec {
# Fixes "SQLite package has not been found installed" at launch
pkgConfig.sqlite3 = {
nativeBuildInputs = [
nodejs.pkgs.node-pre-gyp
node-pre-gyp
python3
sqlite
];
Expand All @@ -48,7 +49,7 @@ mkYarnPackage rec {

pkgConfig.bcrypt = {
nativeBuildInputs = [
nodejs.pkgs.node-pre-gyp
node-pre-gyp
python3
];
postInstall = ''
Expand Down
4 changes: 2 additions & 2 deletions pkgs/servers/mx-puppet-discord/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchFromGitLab, pkgs, lib, nodejs_18, pkg-config
{ stdenv, fetchFromGitLab, pkgs, lib, node-pre-gyp, nodejs_18, pkg-config
, libjpeg, pixman, cairo, pango, which, postgresql }:

let
Expand All @@ -22,7 +22,7 @@ let
in myNodePackages.package.override {
inherit version src;

nativeBuildInputs = [ nodejs.pkgs.node-pre-gyp nodejs.pkgs.node-gyp-build pkg-config which ];
nativeBuildInputs = [ node-pre-gyp nodejs.pkgs.node-gyp-build pkg-config which ];
buildInputs = [ libjpeg pixman cairo pango postgresql ];

postRebuild = ''
Expand Down

0 comments on commit 92f5cb3

Please sign in to comment.