Skip to content

Commit

Permalink
makeInitrd, makeModulesClosure: reduce repetition
Browse files Browse the repository at this point in the history
After #9869.
  • Loading branch information
vcunat committed Sep 15, 2015
1 parent 46ae0a0 commit b5ee55f
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -424,17 +424,13 @@ let

makeAutostartItem = callPackage ../build-support/make-startupitem { };

makeInitrd = { contents, compressor ? "gzip -9n", prepend ? [ ] }:
callPackage ../build-support/kernel/make-initrd.nix {
inherit contents compressor prepend;
};
makeInitrd = { contents, compressor ? "gzip -9n", prepend ? [ ] }@args:
callPackage ../build-support/kernel/make-initrd.nix args;

makeWrapper = makeSetupHook { } ../build-support/setup-hooks/make-wrapper.sh;

makeModulesClosure = { kernel, rootModules, allowMissing ? false }:
callPackage ../build-support/kernel/modules-closure.nix {
inherit kernel rootModules allowMissing;
};
makeModulesClosure = { kernel, rootModules, allowMissing ? false }@args:
callPackage ../build-support/kernel/modules-closure.nix args;

pathsFromGraph = ../build-support/kernel/paths-from-graph.pl;

Expand Down

2 comments on commit b5ee55f

@aszlig
Copy link
Member

@aszlig aszlig commented on b5ee55f Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in cb5e5a5, because this essentially doesn't work, see the commit message for details.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on b5ee55f Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks, I didn't realize that. Some parts of the language still go against my intuition, e.g. NixOS/nix#629.

Please sign in to comment.