[Tracking Issue] __structuredAttrs TODOs and FIXMEs

[Artturin]

Note

Originally started by @Artturin, updated by @ConnorBaker.

This is a tracking issue to follow progress towards __structuredAttrs compatibility in Nixpkgs. This list is not exhaustive; please feel free to add or comment more issue or PRs you feel are related.

Core

Things relating to adding support for __structuredAttrs to setup hooks or tooling used for ecosystems.

Issues

Closed

Nix

• Document __structuredAttrs nix#7429

Nixpkgs

• cmakeFlags cannot parse spaces #114044
• runCommand fails when using __structuredAttrs #213641
• global use of stdenv adapter withCFlags is broken #225740
• makeSetupHook broken in __structuredAttrs __bootPackages  #240753
• cmake: the setup hook breaks with __structuredAttrs = true #289037

Open

Nixpkgs

• addAttrsToDerivation seems broken #306953
• _multioutPropagateDev(): can't set propagatedBuildOutputs with __structuredAttrs #323126
• vmTools.runInLinuxVM fails upon __structuredAttrs = true, complaining mkdir: missing operand #334705

PRs

Closed

Nixpkgs

• WIP: enable __structuredAttrs in stdenv.mkDerivation #65686
• stdenv: enable __structuredAttrs #72074
• stdenv.mkDerivation: add support for env attrset #76732
• stdenv: support __structuredAttrs, opt-in per package #85042
• cmake: add __structuredAttrs support to setup hooks #299622
• stdenv: fix hardeningEnable with __structuredAttrs = true; #353131

Merged

Nix

• Source complete env in nix-shell with __structuredAttrs = true; nix#4770

Nixpkgs

• treewide: structured-attrs fixes #76674
• treewide: Fix types of stripDebugList attrs (and fix doc) #84551
• stdenv: support opt-in __structuredAttrs #175649
• stdenv: handle env gracefully #205944
• stdenv/setup.sh: Allow NIX_ATTRS_{JSON,SH}_FILE to be set correctly by Nix #214937
• treewide: move NIX_CFLAGS_COMPILE to the env attrset  #217206
• buildLuaPackage: enable __structuredAttrs rocks #224553
• stdenvAdapters: fix preservation of env #225787
• stdenvAdapters: fix preservation of env.NIX_CFLAGS_COMPILE #225929
• makeSetupHook: unbreak structuredAttrsByDefault #240759
• structured attrs: prefer NIX_ATTRS_*_FILE over .attrs.* #257919
• lua: enable structuredAttrs for interpreters #264381
• auto-patchelf: add support for __structuredAttrs #272752
• cargoBuildHook: Fix features with __structuredAttrs #302926
• buildDotnetModule: fix structured attributes support #313005
• treewide: support structuredAttrs in setup hooks #318614
• stdenv: concatTo: fallback for non-__structuredAttrs derivations #334973
• treewide: support structuredAttrs in setup hooks (part 2) #335666
• treewide: handle *Phases variables __structuredAttrs-agnostically #339117
• treewide: support structuredAttrs in setup hooks (part 3) #340592
• auto-patchelf: refactor structuredAttrs support #340858
• rust: support structuredAttrs in setup hooks #340862
• enable structuredAttrs for vimPlugins #336042
• stdenv: fix custom hardening settings when using __structuredAttrs = true; #353142

Open

Nixpkgs

• check-meta: warn about misinterpreted *Array variables #335110
• buildPythonPackage, buildPythonApplication: support __structuredAttrs = true #347194
• python3Packages.*Hook: support __structuredAttrs = true (the easier ones) #351734
• treewide: handle *Phases variables __structuredAttrs-agnostically (round 2) #352709

Draft

Nixpkgs

• inputDerivation: support structuredAttrs #215173
• stdenv: run toString on lists in env to allow lists in env #217962
• stdenv and base packages: fix with __structuredAttrs enabled #263773

Misc

Things relating to __structuredAttrs of some note, like discussions or work suspended until better support for __structuredAttrs is implemented.

PRs

Closed

Nixpkgs

• [WIP/RFC] Make cmakeFlags more ergonomic #17886

Merged

Nixpkgs

• make-squashfs,make-iso9660-image: use __structuredAttrs #214373
• cudaPackages.setupCudaHook: init #233581
• stdenv: updateAutotoolsGnuConfigScriptsHook unconditionally #237968
• closureInfo: handle empty path set explicitly #265414

Open

Nixpkgs

• factor-lang: Restructure package for easier extension #287852
• writeClosure: add paths pre-instantiation filtering and sorting #300722
• cmake: setup-hook.sh: add genCmakeDefaultFlags() #335682
• tests.stdenv: Easier to override stdenv #336837

[wolfgangwalther]

cmake and meson (and possibly more?) setup hooks are broken: #289037

[ShamrockLee]

#347194 enables __structuredAttrs support for Python packages. Please take a look.

[ShamrockLee]

#352709 is a continuation of #339117.

[wolfgangwalther]

structuredAttrs and hardeningEnable don't work together well: #353131

[wolfgangwalther]

structuredAttrs and hardeningEnable don't work together well: #353131

Actually fixed in #353142

[wolfgangwalther]

#347194 enables __structuredAttrs support for Python packages. Please take a look.

A part of that is split into #351734.