Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargoBuildHook: Fix features with __structuredAttrs #302926

Merged
merged 1 commit into from
Apr 16, 2024
Merged

cargoBuildHook: Fix features with __structuredAttrs #302926

merged 1 commit into from
Apr 16, 2024

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Apr 9, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@winterqt
Copy link
Member

winterqt commented Apr 9, 2024

Needs to go to staging.

@dasJ
Copy link
Member Author

dasJ commented Apr 10, 2024

Crazy, didn't expect cargoBuildHook/buildRustPackage to be have that much use

@dasJ dasJ force-pushed the fix/buildrustpackage-structuredattrs branch from 7845250 to 6486868 Compare April 10, 2024 07:24
@dasJ dasJ changed the base branch from master to staging April 10, 2024 07:25
@dasJ dasJ requested a review from Lassulus April 16, 2024 08:39
Lassulus
Lassulus approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it looks okay, but not sure about it being correct :)

@Lassulus Lassulus merged commit 55205ec into NixOS:staging Apr 16, 2024
22 checks passed
@ConnorBaker ConnorBaker mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@zowoq zowoq Awaiting requested review from zowoq

@winterqt winterqt Awaiting requested review from winterqt

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dasJ @winterqt @Lassulus