Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsCross.hostPlatform.bash fails to build if buildPlatform.config==hostPlatform.config but buildPlatform!=hostPlatform #264989

Open
ghost opened this issue Nov 2, 2023 · 1 comment
Open

pkgsCross.hostPlatform.bash fails to build if buildPlatform.config==hostPlatform.config but buildPlatform!=hostPlatform #264989

ghost opened this issue Nov 2, 2023 · 1 comment
Labels
0.kind: bug Something is broken 6.topic: cross-compilation Building packages on a different platform than they will be used on

Comments

@ghost
Copy link

ghost commented Nov 2, 2023

We have a longstanding bug (probably more than one of them) where packages don't build properly if the buildPlatform and hostPlatform are not equal, but yet have equal .config attributes.

The equality test for platforms was made more forgiving by

but this merely concealed the problem.
@ghost ghost added the 0.kind: bug Something is broken label Nov 2, 2023
@ghost ghost mentioned this issue Nov 2, 2023
Merged
13 tasks
@ghost
Copy link
Author

ghost commented Nov 2, 2023

Test case is in

@FliegendeWurst FliegendeWurst added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Nov 2, 2023
This was referenced Nov 2, 2023
Merged
Open
@ghost ghost linked a pull request Nov 3, 2023 that will close this issue
gcc.libgcc: compare host and target platforms, rather than their triples #264976
Merged
13 tasks
@ghost ghost removed a link to a pull request Nov 3, 2023
gcc.libgcc: compare host and target platforms, rather than their triples #264976
Merged
13 tasks
ghost pushed a commit that referenced this issue Nov 4, 2023
lib.systems, test.cross.sanity: add test case for #264989
72c279f 
We have several cross-compilation bugs that show up if
hostPlatform!=buildPlatform yet
hostPlatform.config==buildPlatform.config.

These bugs have appeared and disappeared as we've fiddled with the
definition of equality for platform objects.  This commit adds a
clear-cut case where they are *not* equal and never will be, so we
can test it.
@cafkafk cafkafk mentioned this issue Nov 9, 2023
Closed
13 tasks
nyabinary pushed a commit to nyabinary/nixpkgs that referenced this issue Nov 14, 2023
@nyabinary
lib.systems, test.cross.sanity: add test case for NixOS#264989
7f735d2 
We have several cross-compilation bugs that show up if
hostPlatform!=buildPlatform yet
hostPlatform.config==buildPlatform.config.

These bugs have appeared and disappeared as we've fiddled with the
definition of equality for platform objects.  This commit adds a
clear-cut case where they are *not* equal and never will be, so we
can test it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken 6.topic: cross-compilation Building packages on a different platform than they will be used on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FliegendeWurst