Known fetchpatch and fetchpatch2 issues

[pbsds]

Creating this tracking issue in case a fetchpatch3 ever gets made. These are notable issues in the fetchpatch{,2} normalization:

• File moves are ignored by filterdiff twaugh/patchutils#22
  • fetchpatch: ignores file renames #32084
• File permissions/flags are ignored by filterdiff twaugh/patchutils#59
• fetchpatch silently strips binary sections #204320
• fetchpatch2 allows lengths of commit hashes to change #257446

fixes found in the wild:

• anduril/jetpack-nixos@8bf417e

[pbsds]

For those looking for a workaround, use fetchurl with a https://github.com/.../somehash.diff?full_index=1 url to ensure the hash is stable.

?full_index is discussed here: https://github.com/orgs/community/discussions/46034#discussioncomment-4846112

This will not support features like revert = true;

[lheckemann]

It also seems to mangle concatenated patches that introduce a new file and later patch it, like https://github.com/Alexays/Waybar/compare/Alexays:e7c7ef6...picnoir:f99f08b.patch.

[emilazy]

New one: stripLen is applied before includes/excludes, which hardcode -p1, so they don’t interact properly :(