Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleek-grub-theme: unstable-2022-06-04 -> unstable-2024-06-16 #330654

Closed
wants to merge 1 commit into from

Conversation

mf81234
Copy link

@mf81234 mf81234 commented Jul 28, 2024

Description of changes

Updated to latest source commit. Includes fixes and additional icons. Edited withStyle to match.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mf81234
Copy link
Author

mf81234 commented Jul 28, 2024

So sorry for the mass ping on my first attempt, #330644. I believe I've done correctly this time.

@mf81234 mf81234 marked this pull request as ready for review July 28, 2024 13:57
@mf81234
Copy link
Author

mf81234 commented Jul 28, 2024

Pinging maintainer: @luochen1990

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jul 28, 2024
@luochen1990
Copy link
Contributor

LGTM, although there is still issue not fixed, merging this first is not a bad idea.

@mf81234 mf81234 force-pushed the update-sleek-grub-theme branch 2 times, most recently from bb84dcb to 773237b Compare July 28, 2024 18:18
@mf81234
Copy link
Author

mf81234 commented Jul 28, 2024

Sorry for all the mess with my force pushed commits, trying to keep the commit to be merged in one. Changes below:

@mf81234 mf81234 changed the title sleek-grub-theme: unstable-2022-06-04 -> unstable-2023-12-31 sleek-grub-theme: unstable-2022-06-04 -> unstable-2024-06-16 Jul 28, 2024
@luochen1990
Copy link
Contributor

luochen1990 commented Aug 11, 2024

Upstream merged the fix just now. So the patch is no longer needed here

@pbsds pbsds added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 17, 2024
@luochen1990
Copy link
Contributor

Just confirm that this is still active ...

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants