Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure: timescaledb 2.14.2 #341408

Closed
zoechi opened this issue Sep 12, 2024 · 3 comments
Closed

Build failure: timescaledb 2.14.2 #341408

zoechi opened this issue Sep 12, 2024 · 3 comments
Labels
0.kind: build failure A package fails to build

Comments

@zoechi
Copy link

zoechi commented Sep 12, 2024 •
edited
Loading

Steps To Reproduce

Steps to reproduce the behavior:

  1. build X

Build log

error: builder for '/nix/store/7j4vpw2z4ab2p057lc6hvrjdnqwlzbac-timescaledb-2.14.2.drv' failed with exit code 1;
       last 10 log lines:
       > -- Performing Test CC_SUPPORTS_VISIBILITY_HIDDEN
       > -- Performing Test CC_SUPPORTS_VISIBILITY_HIDDEN - Success
       > -- Using compiler GNU
       > -- Could NOT find Git (missing: GIT_EXECUTABLE)
       > CMake Error at CMakeLists.txt:334 (message):
       >   Could not parse PostgreSQL version The real pg_config can be found in the
       >   -dev output.
       >
       >
       > -- Configuring incomplete, errors occurred!
       For full logs, run 'nix log /nix/store/7j4vpw2z4ab2p057lc6hvrjdnqwlzbac-timescaledb-2.14.2.drv'.
error: 1 dependencies of derivation '/nix/store/ni8z0gdnwdyspzskpl256jy724fx00l9-postgresql-and-plugins-15.8.drv' failed to build
error: 1 dependencies of derivation '/nix/store/shnrrda8mafzl4vma4wagdanlrk097ph-postgresql-and-plugins-15.8_fish-completions.drv' failed to build
error (ignored): error: cannot unlink '/var/tmp/nix-daemon/nix-build-tensorflow-2.13.0.drv-1/build/source/tensorflow/compiler/xla/python/tpu_driver': Directory not empty
error: 1 dependencies of derivation '/nix/store/nj7zvxvh0r0nllalh52f82i7ph4vasli-system-path.drv' failed to build
error: interrupted by the user

Additional context

Notify maintainers

@wolfgangwalther (I hope it's ok to tag you)

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.48, NixOS, 24.11 (Vicuna), 24.11.20240906.574d1ea`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/bd4fmzws6n5542khxbifbkr6nrygi232-source`

Add a 👍 reaction to issues you find important.
@zoechi zoechi added the 0.kind: build failure A package fails to build label Sep 12, 2024
@wolfgangwalther
Copy link
Contributor

(I hope it's ok to tag you)

Given the following output....

       > CMake Error at CMakeLists.txt:334 (message):
       >   Could not parse PostgreSQL version The real pg_config can be found in the
       >   -dev output.

... yes, because I introduced that error message.

Will look into what happens there.

wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this issue Sep 12, 2024
@wolfgangwalther
postgresql: improve fake pg_config in default output
fcf27fe 
This fixes some build systems which look up the location of pg_config
via the location of the postgres binary itself, e.g. timescaledb,
instead of calling pg_config which is on PATH.

Since the -dev output is correctly placed before the default output of
postgresql in PATH, we can rely on that and call "pg_config" from the
default output's fake script. Only do that, when the one on PATH is
actually a different file, though, to prevent infinite loops.

Resolves NixOS#341408
@wolfgangwalther wolfgangwalther mentioned this issue Sep 12, 2024
Merged
13 tasks
Lillecarl pushed a commit to Lillecarl/nixpkgs that referenced this issue Sep 21, 2024
@wolfgangwalther
postgresql: improve fake pg_config in default output
13a63cd 
This fixes some build systems which look up the location of pg_config
via the location of the postgres binary itself, e.g. timescaledb,
instead of calling pg_config which is on PATH.

Since the -dev output is correctly placed before the default output of
postgresql in PATH, we can rely on that and call "pg_config" from the
default output's fake script. Only do that, when the one on PATH is
actually a different file, though, to prevent infinite loops.

Resolves NixOS#341408
@anpin
Copy link
Contributor

anpin commented Oct 6, 2024 •
edited
Loading

@wolfgangwalther was it supposed to be fixed be above linked PR? While it was merged timescaledb build still fails on master at 5fe89a8

EDIT: oh I see it was merged to master yet

@wolfgangwalther
Copy link
Contributor

EDIT: oh I see it was merged to master yet

Yeah, it's currently in staging-next: https://nixpk.gs/pr-tracker.html?pr=341421

@vcunat vcunat closed this as completed in 0c47767 Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: build failure A package fails to build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zoechi @anpin @wolfgangwalther