-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vault: add ui #42614
Comments
related PR: #49082 |
I have a solution in that PR that works, but we decided not to merge it into nixpkgs because the yarn dependencies would add too much 'bloat' to nixpkgs. I wonder how we should handle this in the future, as more and more projects seem to bundle a JS web-ui these days, and building those with a fixed set of npm packages in nixpkgs is basically impossible. Does the code in #49082 answer your question @bricewge because in that case we can close this. |
I have read your issues and PRs about JS assets a week or so ago. Thanks to you I know how to bundle such a package now. However I'm quite saddened by the answers on both sides of the aisle. Upstream don't want to vendor in the assets for Writing this comment just made me realize that we didn't ask upstream to make available the compiled assets archive for each release, as Mic92 asked. Maybe it's the way to go since it won't bloat either of the git repo. Anyway I don't think this issue should be closed because it's not resolved. |
That's the best option really. Another option is to create your own nixpkgs overlay for that type of packages. We have a few overlays appearing already, like nixpkgs-wayland. |
Our current solution is https://github.com/obfusk/nix-vault-with-ui, which uses the hashes from yarn.lock to build the UI in the nix sandbox. |
There is also the possibility to use vault-binary that includes the UI ( package) |
Given that this is now packaged, can we close this? |
@PsyanticY thanks for the work! |
use |
Since version
0.10.0
vault
has a web ui which needyarn
to be build. It looks like the derivation need to useyarn2nix
but I can't wrap my head around how to do this inside this derivation. I didn't found any examples on doing this either.Any help or orientation on how to achieve this is welcome.
This issue seems similar to #41378:
træfik
is written in go and also needyarn
to build it's web ui.The text was updated successfully, but these errors were encountered: