-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vault-bin: init at 1.1.3 #65166
vault-bin: init at 1.1.3 #65166
Conversation
I do not agree to package vault from prebuilt binary by default, if you have a good reason we can make separate package called |
Hi @offlinehacker Please have a look here #49082 |
c75792e
to
2e2781a
Compare
per @offlinehacker and @LnL7 recommendation, Proceeding with a separate. |
I assume it's statically compiled and that's why you didn't need patchelf? |
a350bca
to
dc810f7
Compare
@offlinehacker yeah it is statically compiled so no need for |
3f6eb29
to
ec38124
Compare
This binray contain the UI part of HashiCorp Vault that we were not able to build it due to the need to generate a very big yarn file. NixOS#49082
@offlinehacker Should be good now Thanks for the help. |
Thanks, looks good now. I will just do a minor stylistic change, and merge to master 🙂 |
@offlinehacker thanks |
Currently the vault module do not include the ui part of it due to some complications (check this pr: #49082) I think instead of doing the packaging from source we can use the binary Hashicorp is providing that includes the UI.
This is still just a draft and some more work will be made (how to handle darwin and udpate the module with a UI option) if we agree on proceeding using this method.
cc @LnL7 @rushmorem @offline @pradeepchhetri
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)