Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3: switch to python38 for 20.09 #71220

Closed
FRidh opened this issue Oct 16, 2019 · 11 comments
Closed

python3: switch to python38 for 20.09 #71220

FRidh opened this issue Oct 16, 2019 · 11 comments
Assignees
Milestone

Comments

@FRidh
Copy link
Member

FRidh commented Oct 16, 2019

Describe the bug
Use python38 as python3 for 20.03.

  1. Let Hydra build python38Packages
  2. If sufficient packages work for 20.03 we can switch, otherwise we remain at 3.7.
@FRidh FRidh added this to the 20.03 milestone Oct 16, 2019
@FRidh FRidh self-assigned this Oct 16, 2019
FRidh added a commit that referenced this issue Oct 16, 2019
Now that Python 3.8 is released we will also build packages on Hydra.
As soon as the far majority of packages build, we can make Python 3.8
the default `python3`.

#71220
@worldofpeace
Copy link
Contributor

Also, a call to python package maintainers, we need to make sure your packages work with python38 for 20.03.

If you have PRs fixing this please reference this issue, or if you open an issue to reference it also.
That way we can track the status of this by viewing one long-running thread, or you can be notified here.

@jonringer
Copy link
Contributor

For cross reference: #71222

@FRidh
Copy link
Member Author

FRidh commented Jan 5, 2020

2dc4ab3

@jonringer
Copy link
Contributor

@FRidh There's still plenty of the python ecosystem which doesn't support 3.8. Personally, I think this should have waited another month.

@FRidh
Copy link
Member Author

FRidh commented Jan 6, 2020

Looking at python37Packages and python38Packages there wasn't much of a difference. Given the upcoming 20.03 release I do not want to wait another month with making such change or it would get too close to branch-off. Now we can see how many applications are compatible, and if its too few, we can always revert before branch-off.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/1

@FRidh
Copy link
Member Author

FRidh commented Feb 5, 2020

This was reverted.

If we manage to have another staging cycle before branch-off, then we could give it another try, otherwise, we should postpone this to 20.09.

@jonringer
Copy link
Contributor

There was quite a bit of deprecation that took place in python3.8. Personally I'm fine with floating python3 as python3.7 until 20.09

@FRidh FRidh modified the milestones: 20.03, 20.09 Feb 6, 2020
@FRidh FRidh changed the title python3: switch to python38 for 20.03 python3: switch to python38 for 20.09 Feb 6, 2020
@stale
Copy link

stale bot commented Aug 4, 2020

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 4, 2020
@FRidh
Copy link
Member Author

FRidh commented Aug 4, 2020

This has been done. Need to check the documentation and changelog.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 4, 2020
@schmittlauch
Copy link
Member

@FRidh From the 20.03 changelog:

Python 3 now defaults to Python 3.8 instead of 3.7.

So I guess this can be closed.

@FRidh FRidh modified the milestones: 20.09, 21.03 Dec 20, 2020
@FRidh FRidh closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants