Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive the nixpkgs-channels repository #99257

Closed
edolstra opened this issue Oct 1, 2020 · 14 comments
Closed

Archive the nixpkgs-channels repository #99257

edolstra opened this issue Oct 1, 2020 · 14 comments
Assignees
Labels
0.kind: enhancement Add something new
Milestone

Comments

@edolstra
Copy link
Member

edolstra commented Oct 1, 2020

A while ago we added the channel branches (nixos-* etc.) to the nixpkgs repository, so nixpkgs-channels is no longer necessary. However it still exists, which confuses people. I propose to archive it. Thus existing references will still work but we won't add new channels to it.

Concretely:

  • In the channel mirroring script, stop mirroring NixOS >= 20.09. (Also delete the nixos-20.09 branches in nixpkgs-channels. It's not released yet so we can do that.)
  • Once we stop updating NixOS < 20.09, archive the nixpkgs-channel repo.
@edolstra edolstra transferred this issue from NixOS/nix Oct 1, 2020
@edolstra edolstra added the 0.kind: enhancement Add something new label Oct 1, 2020
@edolstra edolstra added this to the 20.09 milestone Oct 1, 2020
@vcunat
Copy link
Member

vcunat commented Oct 1, 2020

Once we stop updating NixOS < 20.09, archive the nixpkgs-channel repo.

That may be a tough condition (e.g. we bumped 19.09 a few days ago), but I think it's OK to stop after they get officially unsupported.

@worldofpeace
Copy link
Contributor

I'm just wondering if the end user could get some kind of warning when their NIX_PATH uses a url to nixpkgs-channels

@worldofpeace
Copy link
Contributor

stop mirroring NixOS >= 20.09. (Also delete the nixos-20.09 branches in nixpkgs-channels. It's not released yet so we can do that.)

This would mean we cannot release 20.09 without this repo being archived first. That makes this a blocker.

@justinlovinger
Copy link
Contributor

stop mirroring NixOS >= 20.09. (Also delete the nixos-20.09 branches in nixpkgs-channels. It's not released yet so we can do that.)

This would mean we cannot release 20.09 without this repo being archived first. That makes this a blocker.

A compromise could be to keep 20.09 in nixpkgs-channels, but not put 21.03 in nixpkgs-channels. At least that would prevent this issue from being a 20.09 blocker.

@veprbl
Copy link
Member

veprbl commented Oct 1, 2020

Once we stop updating NixOS < 20.09, archive the nixpkgs-channel repo.

This will not prevent Hydra from advancing those channels because they are hosted on NixOS.org, right?

@vcunat
Copy link
Member

vcunat commented Oct 1, 2020

Well, there might be some forgotten dependencies like https://github.com/NixOS/nixos-org-configurations/blob/master/modules/tarball-mirror.nix#L37 (just a quick search)

@worldofpeace
Copy link
Contributor

stop mirroring NixOS >= 20.09. (Also delete the nixos-20.09 branches in nixpkgs-channels. It's not released yet so we can do that.)

This would mean we cannot release 20.09 without this repo being archived first. That makes this a blocker.

A compromise could be to keep 20.09 in nixpkgs-channels, but not put 21.03 in nixpkgs-channels. At least that would prevent this issue from being a 20.09 blocker.

Yeah, I really wouldn't want to add another blocker on an already due release. @edolstra Do you think we could have that for 21.03? 20.09 should be ready hopefully fairly soon.

@edolstra
Copy link
Member Author

edolstra commented Oct 2, 2020

This would mean we cannot release 20.09 without this repo being archived first. That makes this a blocker.

I'm not following, why does it mean that?

@vcunat
Copy link
Member

vcunat commented Oct 2, 2020

My understanding of the plan:

  1. Stop pushing 20.09 to nixpkgs-channels repo (without changing anything else) and remove those branches from it. This step should be done before 20.09 is released, so it can be considered a blocker.
  2. Wait until 20.03 is officially unsupported and thus it (and all older) won't be getting many updates anymore. (could be e.g. around the end of 2020 already)
  3. Archive the repo.

@edolstra
Copy link
Member Author

edolstra commented Oct 2, 2020

Right. I can do step 1 today.

@worldofpeace worldofpeace removed this from the 20.09 milestone Oct 2, 2020
@edolstra edolstra self-assigned this Oct 2, 2020
edolstra added a commit to NixOS/nixos-channel-scripts that referenced this issue Oct 2, 2020
@edolstra edolstra added this to the 21.03 milestone Oct 5, 2020
@edolstra
Copy link
Member Author

edolstra commented Oct 5, 2020

Step 1 is done. So nixpkgs-channels doesn't contain branches for nixos-20.09.

I'll set the milestone for this issue to 21.03 as a reminder to archive the repo around then.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/github-com-nixos-nixpkgs-channels-deprecated/9455/3

@domenkozar
Copy link
Member

Should we archive it?

@domenkozar
Copy link
Member

Actually since we already agreed to do it, I just finished this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new
Projects
None yet
Development

No branches or pull requests

7 participants