Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dnsdist: use upstream systemd unit #100060

Merged
merged 1 commit into from
Oct 12, 2020
Merged

nixos/dnsdist: use upstream systemd unit #100060

merged 1 commit into from
Oct 12, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 8, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse force-pushed the dnsdist branch 2 times, most recently from 86af69b to feb52c0 Compare October 9, 2020 11:34
@aanderse aanderse marked this pull request as ready for review October 9, 2020 19:04
@aanderse
Copy link
Member Author

aanderse commented Oct 9, 2020

ping @ShaRose

@aanderse aanderse requested a review from rnhmjoj October 9, 2020 19:16
@aanderse
Copy link
Member Author

@ofborg eval

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 10, 2020
@aanderse aanderse requested a review from dasJ October 11, 2020 15:08
@worldofpeace
Copy link
Contributor

@aanderse See #81138, it does ignore the [Install] section 😦

@aanderse
Copy link
Member Author

Thanks for the info @worldofpeace!

@aanderse aanderse requested a review from rnhmjoj October 12, 2020 14:27
@aanderse
Copy link
Member Author

@rnhmjoj with dnsdist versions 1.5.x and above (which is currently in our master branch) this should work now, as far as I can tell from reading documentation. Does this PR work for you now?

rnhmjoj
rnhmjoj approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@rnhmjoj rnhmjoj merged commit 9b6fc07 into NixOS:master Oct 12, 2020
@aanderse aanderse deleted the dnsdist branch October 12, 2020 19:43
@aanderse aanderse mentioned this pull request Nov 12, 2020
Open
@aanderse aanderse mentioned this pull request Jan 3, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@disassembler disassembler Awaiting requested review from disassembler

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanderse @worldofpeace @rnhmjoj