spidermonkey: drop from all-packages, add to aliases #100089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking out @mkg20001 |
grahamc
reviewed
Oct 9, 2020
| @@ -661,6 +661,8 @@ mapAliases ({ | |||
| youtubeDL = youtube-dl; # added 2014-10-26 | |||
| zdfmediathk = mediathekview; # added 2019-01-19 | |||
| gnome_user_docs = gnome-user-docs; # added 2019-11-20 | |||
| # spidermonkey is not ABI upwards-ompatible, so only allow this for nix-shell | |||
| spidermonkey = spidermonkey_78; # added 2020-10-09 | |||
There was a problem hiding this comment.
A brief note that aliases.nix are enabled by default for users of nixpkgs, and their use is only prohibited from within nixpkgs itself. In other words, nix-shell isn't really the determining factor here.
|
@mkg20001 @worldofpeace This PR causes eval errors for all PRs now, due to ofborg's "no aliases check". It's the 2nd ofborg eval causing commit this day! (cd1b594) To do this change properly, you should iterate over all usages of spidermonkey and remove any usage of the alias. |
10 tasks
|
Yeah, ofborg has been... Anyways, we can fix it by just replacing uses of |
doronbehar
added a commit
that referenced
this pull request
Oct 9, 2020
A fix for #100089 which caused ofborg eval errors on all PRs due to usage of aliases in couchdb and mediatomb.
|
Fixed in 0da82de . |
10 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #100026 (comment)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)