Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cshatag: init at 2019-12-03 #102102

Merged
merged 1 commit into from
Nov 1, 2020
Merged

cshatag: init at 2019-12-03 #102102

merged 1 commit into from
Nov 1, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 29, 2020

Motivation for this change

Silent data corruption paranoia

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102102 run on x86_64-linux 1

1 package marked as broken and skipped:
  • cshatag

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 30, 2020 •
edited
Loading

Result of nixpkgs-review pr 102102 run on x86_64-darwin 1

Edit: Why does ofborg think this builds something on darwin?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Oct 30, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102102 run on x86_64-linux 1

1 package built:
  • cshatag

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 31, 2020

I removed attr from the builds inputs, which I forgot to do earlier. This is needed to run the test suite but it's not working: the tests need user extended attributes which are not availalble in the Nix build sandbox.

@rnhmjoj rnhmjoj merged commit 93e0a06 into NixOS:master Nov 1, 2020
@rnhmjoj rnhmjoj deleted the cshatag branch July 10, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnhmjoj @SuperSandro2000