Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: unify Bash completions outputs #103421

Merged
merged 1 commit into from
Nov 12, 2020
Merged

tree-wide: unify Bash completions outputs #103421

merged 1 commit into from
Nov 12, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Nov 11, 2020

Motivation for this change

Unify the output location where bash completions are being stored. Both
$out/share/bash-completion/completions and $out/etc/bash_completion.d were
being used. This PR starts the unification under the former location.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • gammu
  • prevo-tools
  • todo-txt-cli
  • gitAndTools.git-bug
  • gitAndTools.git-stree
  • gitAndTools.git
  • gitAndTools.top-git
  • purescript
  • backblaze-b2
  • ceph-client - was already broken
  • trace-cmd
  • awscli
  • awscli2
  • google-cloud-sdk
  • tarsnap
  • btrfs-progs
  • yandex-disk
  • gibo
  • powerline-rs
  • pass.extensions.pass-import
  • pass.extensions.pass-update
  • awsebcli
  • nixos-container
  • perlPackages.AppClusterSSH

@zimbatm
tree-wide: unify Bash completions outputs
f5e2ff1 
Use $out/share/bash-completion/completions to store the Bash completions
@zimbatm zimbatm mentioned this pull request Nov 11, 2020
Merged
34 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 labels Nov 11, 2020
jonringer
jonringer approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM so far :)

@zimbatm zimbatm merged commit a7cb88c into NixOS:staging Nov 12, 2020
@zimbatm zimbatm deleted the unified-bash-completion branch November 12, 2020 21:22
@zimbatm
Copy link
Member Author

zimbatm commented Nov 12, 2020

I will follow-up with nix-index once staging has been merged into master.

thefloweringash added a commit to thefloweringash/nixpkgs that referenced this pull request Nov 14, 2020
@thefloweringash
git: fix darwin build
89fd726 
The install step for the darwin specific $out/etc/gitconfig file
assumed that $out/etc already existed. This assumption is no longer
true after f5e2ff1 in NixOS#103421. This
change makes make sure the directory exists before adding to it.
@thefloweringash thefloweringash mentioned this pull request Nov 14, 2020
Merged
10 tasks
primeos pushed a commit that referenced this pull request Nov 14, 2020
@thefloweringash
git: fix darwin build (#103774)
d686ded 
The install step for the darwin specific $out/etc/gitconfig file
assumed that $out/etc already existed. This assumption is no longer
true after f5e2ff1 in #103421. This
change makes make sure the directory exists before adding to it.
@zimbatm zimbatm mentioned this pull request Nov 22, 2020
Merged
16 tasks
freezeboy pushed a commit to freezeboy/nixpkgs that referenced this pull request Nov 25, 2020
@thefloweringash @freezeboy
git: fix darwin build (NixOS#103774)
fcc4fce 
The install step for the darwin specific $out/etc/gitconfig file
assumed that $out/etc already existed. This assumption is no longer
true after f5e2ff1 in NixOS#103421. This
change makes make sure the directory exists before adding to it.

(cherry picked from commit d686ded)
@freezeboy freezeboy mentioned this pull request Nov 25, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimbatm @jonringer