Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.firebase-tools: init at 9.0.1 #107200

Closed
wants to merge 2 commits into from
Closed

nodePackages.firebase-tools: init at 9.0.1 #107200

wants to merge 2 commits into from

Conversation

peterstuart
Copy link

@peterstuart peterstuart commented Dec 19, 2020 •
edited
Loading

Motivation for this change

firebase-tools provides tools for the Firebase service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/413

@SuperSandro2000
Copy link
Member

PR got combined with a few other node updates. Closing so that the update goes trough smoothly.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 2, 2021
Merged
10 tasks
@peterstuart
Copy link
Author

Thanks @SuperSandro2000!

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@dotlambda dotlambda mentioned this pull request Aug 19, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterstuart @nixos-discourse @SuperSandro2000 @Janik-Haag