appgate-sdp: init at 5.1.2

[ymatsiuk]

Motivation for this change

Add appgate-sdp vpn client

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[SuperSandro2000]

Please give autoPatchElfHook a try.

[aanderse]

Does this package include systemd service units? If so you might consider using systemd.packages.

[ymatsiuk]

@aanderse @SuperSandro2000 guys, please take another look into this PR.
what I've done here is:

• wrap binaries instead of manually adding systemd unit files
• use unit files from .deb
• iterate over files in loop and substituteInPlace
• set rpath for all *.so files
• patchelf required binaries
• cleaned up dependencies list (left only required packages)

the only concern I have is substituteInPlace for some files causes warnings - not sure if that's something anyone cares about?
example:

for file in file1 file2 file3; do
  substituteInPlace $file \
    --replace a $out/a \
    --replace b $out/b \
    --replace c $out/c \
    --replace d $out/d
done

if file1 doesn't contain a and file2 b I'll get 2 warnings stating the same. Otherwise I would have to expand the loop. What is the preferred way?

[SuperSandro2000]

the only concern I have is substituteInPlace for some files causes warnings - not sure if that's something anyone cares about?
example:

I think this is fine for now.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108402 run on x86_64-linux 1

1 package built:

• appgate-sdp

[aanderse]

The module LGTM 👍