Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreutils: disable tests which fail in sandbox #116241

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Mar 13, 2021

Is coreutils broken currently? I don't see a failing build on Hydra.

@SuperSandro2000
Copy link
Member Author

I don't think this is broken for hydra but when building it on my machine it is broken. I needed to rebuild the full stdenv for testing futile coreutils stdenv and this prevented me from doing that.

@FRidh FRidh added this to the 21.05 milestone Mar 20, 2021
@veprbl
Copy link
Member

veprbl commented Mar 22, 2021

"futile"? future? Is this for a version bump? I still don't understand, sorry.

@SuperSandro2000
Copy link
Member Author

"futile"? future? Is this for a version bump? I still don't understand, sorry.

I meant to write uutils coreutils stdenv which I was trying at the time.

@SuperSandro2000 SuperSandro2000 merged commit 1f831f0 into NixOS:staging Jun 1, 2021
@SuperSandro2000 SuperSandro2000 deleted the coreutils-sandbox branch June 1, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants